Skip to content

Update conf.py to execute imports during pdf building #38841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

Update conf.py to execute imports during pdf building #38841

merged 1 commit into from
Jan 5, 2021
+1 −1

Conversation

gepcel
Copy link
Contributor

@gepcel gepcel commented Dec 31, 2020 •
edited by simonjayhawkins
Loading

closes #38451

According https://ipython.readthedocs.io/en/stable/sphinxext.html, it should be ipython_execlines not ipython_exec_lines. Should close issue #38451

@gepcel
Update conf.py to execute imports during pdf building
06cc88b 
According [https://ipython.readthedocs.io/en/stable/sphinxext.html](), it should be `ipython_execlines` not `ipython_exec_lines`. Should close issue #38451
@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

hmm so it is.

@jreback jreback added the Docs label Dec 31, 2020
@jreback jreback added this to the 1.3 milestone Dec 31, 2020
@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

cc @simonjayhawkins

@simonjayhawkins simonjayhawkins modified the milestones: 1.3, 1.2.1 Dec 31, 2020
simonjayhawkins
simonjayhawkins requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gepcel for the PR. will check pdf doc build shortly on my release environment for 1.2 with this change

changed milestone as we will want to backport this, if merged.

@jreback
Copy link
Contributor

jreback commented Jan 3, 2021

@simonjayhawkins how's this looking

@simonjayhawkins
Copy link
Member

will merge this to close #38451 as it does prevent the NameError.

However, something else is awry since {{ header }} still appears in the pdf docs.

During the first run of ./make.py latex_forced it appears in 10 minutes to pandas and no contents are created. we run a second time (I assume to get the contents to build) and on the second run the visualisaztion section is recreated (why this happens is they key to solving this properly) but without the header code being run but the change here means that we don't get the NameErrors

@simonjayhawkins simonjayhawkins merged commit c386fbb into pandas-dev:master Jan 5, 2021
@simonjayhawkins
Copy link
Member

Thanks @gepcel

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 5, 2021
@gepcel @meeseeksmachine
Backport PR pandas-dev#38841: Update conf.py to execute imports durin…
1edb480 
…g pdf building
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 5, 2021
Merged
jreback pushed a commit that referenced this pull request Jan 5, 2021
@meeseeksmachine @gepcel
Backport PR #38841: Update conf.py to execute imports during pdf buil…
20e13fa 
…ding (#38970)

Co-authored-by: WANG Aiyong <[email protected]>
@gepcel gepcel deleted the patch-1 branch January 6, 2021 00:41
@gepcel
Copy link
Contributor Author

gepcel commented Jan 6, 2021

However, something else is awry since {{ header }} still appears in the pdf docs.

That might because the section (reference) name is "visualization" and the section title is also "visualization", therefore the Duplicate implicit target name: "visualization".

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@gepcel @luckyvs1
Update conf.py to execute imports during pdf building (pandas-dev#38841)
a3bdaf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

DOC: name not defined in section "2.14.1 Basic plotting: plot"
3 participants
@gepcel @jreback @simonjayhawkins